[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/ConstantInitBuilder.cpp:132 + return getRelativeOffsetToPosition(offsetType, target, + Builder.SelfReferences.size()); +} Shouldn't this be

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, alright. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/ https://reviews.llvm.org/D77592

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

leonardchan added a comment. @rjmccall Would it be fine to submit this since you gave LGTM on D72959 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/ https://reviews.llvm.org/D77592