[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. In D77641#2004273 , @Szelethus wrote: > I think you can go ahead and commit. You seem to have a firm grasp on this > project, I believe your experience with ASTImporter has more then prepared > you for digging functions out of

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG62e747f61729: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Szelethus added a comment. I think you can go ahead and commit. You seem to have a firm grasp on this project, I believe your experience with ASTImporter has more then prepared you for digging functions out of the `std` namespace, or whatever else that might come up :^) Repository: rG LLVM

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77641/new/ https://reviews.llvm.org/D77641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. @NoQ Do these changes look okay to land? Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77641/new/ https://reviews.llvm.org/D77641 ___ cfe-commits mailing list

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. In D77641#1969412 , @NoQ wrote: > So you only do the lookup in the global scope? What about `namespace std`? > > Do you also plan to support class methods by looking up the class first and > then looking up the method in the

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. In D77641#1969291 , @Szelethus wrote: > I suspect your change made compiler errors a bit nicer as well, so you don't > get one giant "Well, this huge single argument doesn't match any of the > assignment operators". The

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

NoQ added a comment. So you only do the lookup in the global scope? What about `namespace std`? Do you also plan to support class methods by looking up the class first and then looking up the method in the class? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Szelethus added a comment. Also, if you gave a bit of time for anyone else to have a say, that might be nice. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77641/new/ https://reviews.llvm.org/D77641

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Its always a joy to see you do C++. I suspect your change made compiler errors a bit nicer as well, so you don't get one giant "Well, this huge single argument doesn't look

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, uenoku, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:570 +llvm::Optional +lookupGlobalCFunction(StringRef Name, const ASTContext ) { + IdentifierInfo = ACtx.Idents.get(Name);