[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

2020-04-08 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcca10be3f60d: [clangd] Fix a crash bug in AddUsing tweak around template handling. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

2020-04-08 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz marked an inline comment as done. adamcz added a comment. Can you submit this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77656/new/ https://reviews.llvm.org/D77656 ___ cfe-commits

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

2020-04-08 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 255950. adamcz added a comment. review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77656/new/ https://reviews.llvm.org/D77656 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

2020-04-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Whoops, indeed. There should be a version of falsehoods programmers believe about names for the clang

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

2020-04-07 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. adamcz updated this revision to Diff 255694. adamcz added a comment. Removed unnecessary change.

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

2020-04-07 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 255694. adamcz added a comment. Removed unnecessary change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77656/new/ https://reviews.llvm.org/D77656 Files: