[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

2020-04-09 Thread Matthias Gehre via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeaa55590945a: [clang-tidy] misc-unused-parameters: Dont remove parameter from lambda (authored by mgehre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

2020-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM as a temporary workaround until we find a better solution. (I just noticed that we don't need a similar fix for blocks because this check doesn't seem to support blocks:

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

2020-04-08 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added a comment. In D77680#1968860 , @njames93 wrote: > Outright disabling for lambdas probably isn't the ideal solution, however > it's at least a good stepping stone til a better solution can be found. I fully agree! Repository: rG LLVM

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

2020-04-08 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Outright disabling for lambdas probably isn't the ideal solution, however it's at least a good stepping stone til a better solution can be found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77680/new/

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

2020-04-07 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre created this revision. mgehre added reviewers: aaron.ballman, alexfh, hokein, njames93. Herald added a subscriber: xazax.hun. Herald added a project: clang. mgehre added a project: clang-tools-extra. mgehre edited the summary of this revision. Previously, the check would fix using fn =