This revision was automatically updated to reflect the committed changes.
Closed by commit rGbf968e28ee82: [ASTMatchers] Add support for dynamic matching
of ofKind narrowing matcher (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106
+ static constexpr llvm::StringRef Allowed[] = {
+ "UETT_SizeOf", "UETT_AlignOf",
+ "UETT_VecStep",
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106
+ static constexpr llvm::StringRef Allowed[] = {
+ "UETT_SizeOf",
njames93 updated this revision to Diff 256262.
njames93 marked 4 inline comments as done.
njames93 added a comment.
Added test cases and address nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77791/new/
https://reviews.llvm.org/D77791
Files:
njames93 added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106
+ static constexpr llvm::StringRef Allowed[] = {
+ "UETT_SizeOf", "UETT_AlignOf",
+ "UETT_VecStep", "UETT_OpenMPRequiredSimdAlign",
+
aaron.ballman added a comment.
Thank you for this! It basically LG, but can you also add a dynamic matcher
unit test for this functionality?
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:102-106
+ static constexpr llvm::StringRef Allowed[] = {
+
njames93 created this revision.
njames93 added reviewers: klimek, aaron.ballman.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Adds support for using the ofKind in clang-query and other dynamic matcher use
cases
Repository:
rG LLVM
