[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

dmgreen added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + LukeGeeson wrote: > dmgreen wrote: > > I don't think that

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + dmgreen wrote: > I don't think that hasNoSchedulingInfo is necessarily the best

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + I don't think that hasNoSchedulingInfo is necessarily the best way to handle this. That flag is intended for instructions that

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

This revision was automatically updated to reflect the committed changes. LukeGeeson marked an inline comment as done. Closed by commit rG7da190512532: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77872/new/ https://reviews.llvm.org/D77872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but please wait a couple more days before committing to see if anyone wants to chime in (I guess one week since the upload date should be enough). CHANGES SINCE LAST ACTION

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson marked 3 inline comments as done. LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson updated this revision to Diff 258030. LukeGeeson added a comment. - added -sroa to arm-v8.6a-neon-intrinsics test, updated test to remove redundant memory accesses - made class vusdot for new vusdot instructions with hasNoSchedulinginfo for new instructions. Existing instructions

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki added inline comments. Comment at: clang/test/CodeGen/arm-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck %s Can you try -sroa after

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson added a comment. Harbourmaster now biulds, and unit tests pass, errors related to linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77872/new/ https://reviews.llvm.org/D77872 ___

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics. LukeGeeson