[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

This revision was automatically updated to reflect the committed changes. Closed by commit rG2899103108d3: [TimeProfiler] Emit clock synchronization point (authored by broadwaylamb). Changed prior to commit: https://reviews.llvm.org/D78030?vs=258061=259413#toc Repository: rG LLVM Github

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. @russell.gallop thanks! I'll address your comments and commit the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 ___ cfe-commits mailing list

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

russell.gallop accepted this revision. russell.gallop added a comment. LGTM, with a few small comments. For the record, I wondered whether the time profiler could emit all ts as absolute, so I tried it out. This has two problems. 1). The "Total" numbers also need adjusting to be at the

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. Since we're adding a new attribute here that we won't ever be able to remove in the future, I'd still like to get a LGTM from some of the folks that are familiar with the time profiler. @russell.gallop @anton-afanasyev? CHANGES SINCE LAST ACTION

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb updated this revision to Diff 258061. broadwaylamb added a comment. A simpler generation of the beginning of time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 Files: clang/test/Driver/check-time-trace-sections.py

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

MaskRay added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", + BeginningOfTimeUs.time_since_epoch().count());

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

MaskRay added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", + BeginningOfTimeUs.time_since_epoch().count()); What is

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added a comment. It'd be good if I had one more LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb updated this revision to Diff 257340. broadwaylamb added a comment. Indent patterns in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 Files:

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

MaskRay added inline comments. Comment at: lld/test/ELF/time-trace.s:21 -# CHECK: "traceEvents": [ +# CHECK: "beginningOfTime": {{[0-9]{16},}} +# CHECK-NEXT: "traceEvents": [ Add 5 spaces after `:` so that the key is aligned Repository: rG LLVM Github

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb created this revision. broadwaylamb added reviewers: anton-afanasyev, russell.gallop, espindola. Herald added subscribers: cfe-commits, MaskRay, hiraditya, emaste. Herald added a project: clang. broadwaylamb added a parent revision: D78027: [TimeProfiler] Emit real process ID and