[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe90fb82f0f76: [AST] Suppress the spammy attempt to use a deleted fucntion diagnostic. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D78100?vs=257689=258918#toc Repository:

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall added a comment. OK LG without changes Comment at: clang/lib/Sema/SemaDecl.cpp:12565 + auto RecoveryExpr = + CreateRecoveryExpr(Var->getLocation(), Var->getEndLoc(), {}); + if (RecoveryExpr.get()) hokein wrote: > sammccall wrote: >

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12565 + auto RecoveryExpr = + CreateRecoveryExpr(Var->getLocation(), Var->getEndLoc(), {}); + if (RecoveryExpr.get()) sammccall

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG but please fix the sourcerange Comment at: clang/lib/Sema/SemaDecl.cpp:12268 /// of sanity. void Sema::ActOnInitializerError(Decl *D) { // Our main concern

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12268 /// of sanity. void Sema::ActOnInitializerError(Decl *D) { // Our main concern here is re-establishing invariants like "a hokein wrote: > sammccall wrote: > > rsmith wrote: > > >

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein updated this revision to Diff 257689. hokein marked 4 inline comments as done. hokein added a comment. address comments: - don't modify the existing tests - add new tests for -frecovery-ast only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11985-11986 }); if (Res.isInvalid()) { VDecl->setInvalidDecl(); } else if (Res.get() != Args[Idx]) { rsmith wrote: >

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall added a comment. In D78100#1981729 , @rsmith wrote: > In D78100#1981620 , @sammccall wrote: > > > Sorry to go back and forth on this, but I'm not sure whether these > > diagnostics are actually spam to

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

rsmith added a comment. In D78100#1981620 , @sammccall wrote: > Sorry to go back and forth on this, but I'm not sure whether these > diagnostics are actually spam to be suppressed. I think @adamcz mentioned > these today as reasonable diagnostics we're

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall added subscribers: adamcz, rsmith. sammccall added a comment. Sorry to go back and forth on this, but I'm not sure whether these diagnostics are actually spam to be suppressed. I think @adamcz mentioned these today as reasonable diagnostics we're enabling. @rsmith do you have an

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein updated this revision to Diff 257302. hokein added a comment. fix the broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78100/new/ https://reviews.llvm.org/D78100 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. This patch fixes the regression diagnostic, which was introduced in https://reviews.llvm.org/D77395. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78100 Files: