[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Thanks, Just sent Tom an email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Best to ask the release manager. Today Tom Stellard posted a message to the llvm dev list with subject: [llvm-dev] LLVM 10.0.1-rc1 release update So best to reply to this(*) asap with your query if it's possible to get this onto the branch. (*)

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I have a question here. Our customers need the TX3 support urgently, they asked me to put this TX3 support to LLVM 10.0.1 and if there is 9.0.2 release planned, they also need it there. How can I do this? To put this checkin to LLVM 10.0.1 branch and 9.0.2 branch? Is

[PATCH] D78129: Add Marvell ThunderX3T110 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG382d3a85e2a9: [AARch64] Add Marvell ThunderX3T110 support (authored by wxz2020, committed by joelkevinjones). Changed prior to commit: https://reviews.llvm.org/D78129?vs=263582=263896#toc Repository:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Joel will help me to commit it. Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Forgot to ask/add: can you commit this, do you have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263582. wxz2020 added a comment. Correct the wrong version of llvm/unittests/Support/TargetParserTest.cpp which causes the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263543. wxz2020 added a comment. 1. in clang/test/Driver/aarch64-cpus.c, expanded the the same tests for thunderx2t99 to thunderx3t110 2. in llvm/unittest/Support/TargetParserTest.cpp, fix the missing target features So far all the existing issues are

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. This looks good now, but sorry, one more request: I've just noticed a Clang driver test is missing. Can you add a test for this to `clang/test/Driver/aarch64-cpus.c`? And related to this, the relevant tests to `llvm/unittests/Support/TargetParserTest.cpp`?

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263081. wxz2020 added a comment. fix a typo, thunderx3t110, not thunderx3t100 in TargetParserTest.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263079. wxz2020 added a comment. Fix the format issue in TargetParserTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263070. wxz2020 added a comment. 1. Added the predicates as suggested 2. brought back the TargetParserTest.cpp which was missed last time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Sure I will add Joel's suggestion and other fixes later. Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. In D78129#2023772 , @joelkevinjones wrote: > I don't think it makes sense to combine two unrelated things SVE and PA > support into a combined thing. Since we already have UnsupportedFeatures in > every sub-target .td

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I think I made all the changes mentioned in the feedbacks. Please take sometime to review the current version. We are eager to get the first thunderx3t110 checked in. There are a few things we plan to do after the 1st version: 1. add more tests as suggested in the

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 262876. wxz2020 added a comment. Removed the PA related instructions from the .md file as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Let's separate out HasPA from SVEFeatures now while we are at it, probably it's more work to do this as a follow up, and after that this looks good to me. Bonus points for adding some llvm-mca tests, see the `llvm-project/llvm/test/tools/llvm-mca/` directory for

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I will put the "PAUnsupported" predicate later once this got passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 262665. wxz2020 added a comment. I put every people's feedbacks into the code and upload them here. I think we can use it as the start point for TX3, and add more when we move on. Thank you all for great help, Repository: rG LLVM Github Monorepo

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Agreed about the UnsupportedFeatures list. But I just wanted to unblock this work, create a first version that compiles, so you can pick it up and clean things further up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78129: Add Marvell ThunderX3T110 support

evandro added a comment. In D78129#2023772 , @joelkevinjones wrote: > list UnsupportedFeatures = !listconcat(SVEUnsupported.F, > PAUnsupported.F); > Agree. Methinks that this is easier to read. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D78129: Add Marvell ThunderX3T110 support

joelkevinjones added a comment. I don't think it makes sense to combine two unrelated things SVE and PA support into a combined thing. Since we already have UnsupportedFeatures in every sub-target .td file, I think it would be better to instead have: def PAUnsupported : AArch64Unsupported {

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I can confirm your findings, basically as long as we comment out the new instructions, it will be OK to build. Agree with your changes 1), 2) and 3). 4. this seems does not matter to build, as long as we comment out the new instructions in 5), setting it "1" or "0",

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Since debugging on phabricator is a bit difficult, I took the patch and had a little play. Now I actually remember seeing this before. I think the way this works is that when you describe new instructions (PA in this case) that other models don't have, they start

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked an inline comment as done. wxz2020 added a comment. I tried to set CompleteModel = 0 on line 25 in file llvm/lib/Target/AArch64/AArch64SchedThunderX3T110.td The same error is still there. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +//

[PATCH] D78129: Add Marvell ThunderX3T110 support

joelkevinjones added a comment. > It is okay'ish to set `CompleteModel = 0` if you're not interested in > describing all instructions. The other way is of course to add the missing > instruction to the model. We are trying to describe all instructions. The issue Wei is having is that the

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. In D78129#2022307 , @joelkevinjones wrote: > In email Wei asked for help about he following error message: > > error message from tblgen > Included from >

[PATCH] D78129: Add Marvell ThunderX3T110 support

joelkevinjones added a comment. In email Wei asked for help about he following error message: error message from tblgen Included from /home/wei/project/tx3/llvm-project/llvm/lib/Target/AArch64/AArch64.td:439:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 261497. wxz2020 marked an inline comment as done. wxz2020 added a comment. fixed all the feedback suggestions. Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked 7 inline comments as done. wxz2020 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89 CPU = llvm::sys::getHostCPUName(); - if (CPU == "generic") { DavidSpickett wrote: > Remove stray change. Removed

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:849 + HasV8_1aOps, + HasV8_3aOps]>; + `HasV8_3aOps` implies `HasV8_2aOps`, which implies

[PATCH] D78129: Add Marvell ThunderX3T110 support

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89 CPU = llvm::sys::getHostCPUName(); - if (CPU == "generic") { Remove stray change. Comment at:

[PATCH] D78129: Add Marvell ThunderX3T110 support

DavidSpickett added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:168 + (AArch64::AEK_CRC | AEK_CRYPTO | AEK_FP | AEK_SIMD | AEK_LSE | AEK_RAND)) +AARCH64_CPU_NAME("thunderx3t110", ARMV8_3A, FK_CRYPTO_NEON_FP_ARMV8, false, +

[PATCH] D78129: Add Marvell ThunderX3T110 support

chill added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in { def PACIAZ : SystemNoOperands<0b000,

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked an inline comment as done. wxz2020 added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in {

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 260680. wxz2020 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Remove non-official target options. We now only support -mcpu=thunderx3t110 Typo fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked 2 inline comments as done. wxz2020 added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in {

[PATCH] D78129: Add Marvell ThunderX3T110 support

ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in { def PACIAZ : SystemNoOperands<0b000,

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Fix a format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 259737. wxz2020 added a comment. fix a format issus. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp llvm/include/llvm/Support/AArch64TargetParser.def

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 259605. wxz2020 added a comment. Resubmit as the previous one was rejected by test plan changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 257876. wxz2020 added a comment. The newly added two files were not accepted by the pre-merge check. Re worked on the diff file and uploaded it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 created this revision. wxz2020 added reviewers: joelkevinjones, pankajgode. Herald added subscribers: cfe-commits, jfb, hiraditya. Herald added a project: clang. This is the first checkin to support Marvell ThunderX3T110. Initial definition of the micro-ops of the instructions in