This revision was automatically updated to reflect the committed changes.
Closed by commit rG0642e5e7a7e5: [clang-tidy] modernize-use-using: Fix broken
fixit with template keyword (authored by mgehre).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks for fixing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78139/new/
https://reviews.llvm.org/D78139
mgehre updated this revision to Diff 257774.
mgehre marked an inline comment as done.
mgehre added a comment.
Implement review comments (Thanks!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78139/new/
https://reviews.llvm.org/D78139
Files:
njames93 added inline comments.
Comment at: clang/lib/AST/NestedNameSpecifier.cpp:314
+InnerPolicy);
+} else if (const auto *SpecType =
+ dyn_cast(T)) {
Can this be renamed as it shadows the `SpecType`
mgehre created this revision.
mgehre added reviewers: aaron.ballman, alexfh, hokein, njames93.
Herald added a subscriber: xazax.hun.
Herald added a project: clang.
Before this PR, `modernize-use-using` would transform the typedef in
template class TemplateKeyword {
typedef typename
