[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG002164461b52: [SveEmitter] Add builtins for FP conversions (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78239?vs=258426=259504#toc Repository: rG LLVM Github Monorepo

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/SveEmitter.cpp:1035 + OS << "#define svcvtxnt_f32_x svcvtxnt_f32_m\n"; + OS << "#define svcvtxnt_f32_f64_x

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen updated this revision to Diff 258426. sdesmalen added a comment. - Added comment to CGBuiltin explaining that the special case for IsFPConvert will be removed in a follow-up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78239/new/ https://reviews.llvm.org/D78239

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen marked an inline comment as done. sdesmalen added a comment. In D78239#1987859 , @efriedma wrote: > I think the predicate type is something we should fix. Even if it's not > causing problems now, it seems like the sort of thing that will bite

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma added a comment. I think the predicate type is something we should fix. Even if it's not causing problems now, it seems like the sort of thing that will bite us later. It doesn't necessarily need to block this patch, I guess, but it at least needs a good comment in

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen added a comment. In D78239#1985102 , @efriedma wrote: > > as the LLVM IR intrinsics use the as the predicate. > > Why are the fp conversion intrinsics special here? Should we fix the LLVM > intrinsic definitions? I questioned that as well,

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma added a comment. > as the LLVM IR intrinsics use the as the predicate. Why are the fp conversion intrinsics special here? Should we fix the LLVM intrinsic definitions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78239/new/

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr. sdesmalen added a child revision: D77597: