[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

This revision was automatically updated to reflect the committed changes. Closed by commit rG239c53b72b18: [analyzer] Track runtime types represented by Obj-C Class objects (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added a comment. Perfect! Please get yourself some commit access already -__- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 ___ cfe-commits mailing list

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 260580. vsavchenko added a comment. Move getSelfSVal from CallEvent to ProgramState Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files:

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko marked 2 inline comments as done. vsavchenko added a comment. > Let's land this, I guess? Fantastic work! Thanks :-) Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Let's land this, I guess? Fantastic work! Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. +

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 259314. vsavchenko marked 9 inline comments as done. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files:

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko marked 7 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:113 + +bool isObjCClassType(QualType Type) { + if (const auto *PointerType = dyn_cast(Type)) { NoQ wrote: >

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:113 + +bool isObjCClassType(QualType Type) { + if (const auto *PointerType = dyn_cast(Type)) { `static`? Comment at:

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:217-218 void DynamicTypePropagation::checkDeadSymbols(SymbolReaper , CheckerContext ) const { ProgramStateRef State =

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 258065. vsavchenko marked 8 inline comments as done. vsavchenko added a comment. Fix issues pointed by @NoQ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files:

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko marked 6 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:135 + if (MsgE->getReceiverKind() == ObjCMessageExpr::Class) { +return {MsgE->getClassReceiver()->getAs(), true}; + }

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:135 + if (MsgE->getReceiverKind() == ObjCMessageExpr::Class) { +return {MsgE->getClassReceiver()->getAs(), true}; + } Let's explain what `true` means here,

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 258003. vsavchenko added a comment. Fix unfinished comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files:

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Objective-C