[PATCH] D78350: [AST] Build recovery expressions by default for C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ea1059df97: [AST][RecoveryExpr] Build recovery expressions by default for C++. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 270370. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein added a comment. ok, the current status seems quite stable now. We rolled it out to all our internal users for a while, didn't see big crashes. I'm going to land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 269859. hokein marked 2 inline comments as done. hokein added a comment. rebase to master and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files:

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 268105. hokein added a comment. rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 263647. hokein added a comment. rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Code LG, let's chat before landing though - want to understand the state of the internal testing. Comment at: clang/include/clang/Basic/LangOptions.def:151

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein marked an inline comment as done. hokein added a comment. In D78350#2009345 , @hubert.reinterpretcast wrote: > In D78350#2007065 , @hokein wrote: > > > In D78350#2006469

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

rsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:151 -COMPATIBLE_LANGOPT(RecoveryAST, 1, 0, "Preserve expressions in AST when encountering errors") +COMPATIBLE_LANGOPT(RecoveryAST, 1, CPlusPlus, "Preserve expressions in AST when

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. In D78350#2007065 , @hokein wrote: > In D78350#2006469 , > @hubert.reinterpretcast wrote: > > > Got it. I'll put together a build. > > > Thank you! Look forward to the

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 260552. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein marked 8 inline comments as done. hokein added a comment. In D78350#2006469 , @hubert.reinterpretcast wrote: > In D78350#1988416 , @hokein wrote: > > > @ebevhan, @hubert.reinterpretcast, the patch is based

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. In D78350#1988416 , @hokein wrote: > @ebevhan, @hubert.reinterpretcast, the patch is based on > fd7a34186137168064ffe2ca536823559b92d939 > , it

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 260306. hokein added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 259514. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein added subscribers: ebevhan, hubert.reinterpretcast. hokein added a comment. @ebevhan, @hubert.reinterpretcast, the patch is based on fd7a34186137168064ffe2ca536823559b92d939 , it should contain all the fixes. it would

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein updated this revision to Diff 258268. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. hokein added subscribers: ebevhan, hubert.reinterpretcast.

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 258268. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. fix clangd test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350