This revision was automatically updated to reflect the committed changes.
Closed by commit rG4b53495c4ba2: Perform ActOnConversionDeclarator after
looking for any virtual functions it… (authored by rdwampler).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
rdwampler updated this revision to Diff 263466.
rdwampler added a comment.
Fixed indentation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78444/new/
https://reviews.llvm.org/D78444
Files:
clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaDeclCXX.cpp
clang/test/SemaCXX/conversion-f
rjmccall added a comment.
LGTM with a minor fix.
Comment at: clang/lib/Sema/SemaDecl.cpp:10745
+if (CXXConversionDecl *Conversion = dyn_cast(NewFD))
+ ActOnConversionDeclarator(Conversion);
Indentation is off.
CHANGES SINCE LAST ACTION
https:
rdwampler added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78444/new/
https://reviews.llvm.org/D78444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rdwampler updated this revision to Diff 258613.
rdwampler added a comment.
changed to check it overrides a virtual function in a base class and not just
virtual.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78444/new/
https://reviews.llvm.org/D78444
Files:
clang/lib/Sema/SemaDecl.c
rdwampler created this revision.
rdwampler added reviewers: saar.raz, aaron.ballman, doug.gregor, rsmith.
rdwampler added a project: clang.
Herald added subscribers: cfe-commits, dexonsmith.
This allows for suppressing warnings about the conversion function never being
called if it overrides a vi
