[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

JonChesterfield abandoned this revision. JonChesterfield added a comment. No problem. This isn't on the live path - the function is mostly called from openmp codegen and clang doesn't target openmp/amdgcn just yet. I'll roll this change into the codegen patch to enable that. Repository: rG

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

rjmccall added a comment. You're not testing an assertion, you're testing that code is generated correctly for some file on amdgcn. Just write an ordinary IR-generation test that currently crashes and this test fixes. This is not an NFC change. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

JonChesterfield added a comment. In D78495#1992404 , @arsenm wrote: > Needs test? I'm not sure how to write said test. How do we normally hit asserts from the clang test suite? This fires a lot in the openmp on amdgcn downstream branch, but I'm happy

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

arsenm added a comment. Needs test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78495/new/ https://reviews.llvm.org/D78495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78495: [nfc] Accept addrspacecast allocas in InitTempAlloca

JonChesterfield created this revision. JonChesterfield added reviewers: rjmccall, aaron.ballman, ABataev, jdoerfert, arsenm. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. [nfc] Accept addrspacecast allocas in InitTempAlloca Changes the precondition to be slightly