Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

On Wed, Apr 29, 2020 at 12:52 AM Eric Christopher wrote: > I've had to temporarily revert this as it was breaking some tests: > > .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: > use of undeclared identifier 'set' > set(Value); > ^ > 1 error

Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

I've had to temporarily revert this as it was breaking some tests: .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: use of undeclared identifier 'set' set(Value); ^ 1 error generated. Happy to help diagnose this with you if you need some assistance.

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep added a comment. Great, thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501 ___ cfe-commits mailing list

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rGad38f4b371bd: Add a facility to get system cache directory and use it in clangd (authored by VojtechStep, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall added a comment. Sorry about the delay, ran into some problems with the tests and decided to simplify them a little by extracting the helper. Also I think the subdirectory inside $XDG_CACHE_HOME isn't supposed to be hidden, so .clangd->clangd which meant a little refactoring. Thanks

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall updated this revision to Diff 260768. sammccall added a comment. Use $cache/clangd/index, not $cache/.clangd/index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501 Files:

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall updated this revision to Diff 260757. sammccall added a comment. Fix(?) test compile for windows, split out windows/unix tests for simplicity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep added a comment. Herald added a project: LLVM. Ping @sammccall, could you commit the changes? Thanks  CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501 ___ cfe-commits mailing list

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep updated this revision to Diff 258805. VojtechStep edited the summary of this revision. VojtechStep added a comment. @sammccall I think I fixed all raised issues. Let me know if there is anything else I can do, otherwise feel free to commit it. Also Note to self: Once this is pushed

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Looks good with a few nits. Once you're done, let me know if I should land this for you (after a few patches landed this way you can apply for commit access:

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep created this revision. VojtechStep added reviewers: sammccall, chandlerc, Bigcheese. VojtechStep added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, ormris, kadircet, arphaman, dexonsmith, jkorous, MaskRay, ilya-biryukov, hiraditya. Herald added a