[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

2021-01-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D78513#1993210 , @hliao wrote: > In D78513#1993115 , @yaxunl wrote: > >> Currently if instructions of float128 get to amdgpu backend, are we going to >> crash? > > As `Float128Format`

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

2020-04-21 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG86e3b735cd80: [hip] Claim builtin type `__float128` supported if the host target supports it. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

2020-04-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78513/new/ https://reviews.llvm.org/D78513

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

2020-04-20 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D78513#1993115 , @yaxunl wrote: > Currently if instructions of float128 get to amdgpu backend, are we going to > crash? As `Float128Format` is re-defined as `double`, there won't be any issue in the backend. But, it won't

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

2020-04-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Currently if instructions of float128 get to amdgpu backend, are we going to crash? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78513/new/ https://reviews.llvm.org/D78513

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

2020-04-20 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added subscribers: cfe-commits, kerbowa, nhaehnle, jvesely. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78513 Files: clang/lib/Basic/Targets/AMDGPU.cpp