Xiangling_L abandoned this revision.
Xiangling_L added a comment.
Current implementation conflicts with __AlignOf behavior as we discussed in
[RFC] Adding AIX power alignment rule in clang front end
(http://lists.llvm.org/pipermail/cfe-dev/2020-April/065324.html) . Drop this
revision and a
Xiangling_L updated this revision to Diff 259559.
Xiangling_L marked 5 inline comments as done.
Xiangling_L added a comment.
Adjust some comments style;
Add more testcases;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78563/new/
jasonliu added inline comments.
Comment at: clang/include/clang/AST/RecordLayout.h:81
+ /// AIXOffsetAlignment - The special AIX Alignment for the object that
+ /// contains floating-point member or sub-member. This is for AIX-abi only.
AIX Alignment -> AIX
jasonliu added inline comments.
Comment at: clang/include/clang/AST/RecordLayout.h:177
+ /// getAIXOffsetAlignment - Get the record of aixOffset alignment in
+ /// characters.
Not sure if aixOffset is a thing? Might be better to just say "aix offset
jasonliu added inline comments.
Comment at: clang/test/Layout/aix-double-struct-member.cpp:136
+// CHECK-NEXT:| nvsize=12, nvalign=4]
+}; // namespace test4
1. I think we also want to test empty base class with a derived class contains
double as
Xiangling_L created this revision.
Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, sfertile.
Xiangling_L added a project: LLVM.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Address the following aspects of power alignment rules:
- Implemented double/long
