This revision was automatically updated to reflect the committed changes.
Closed by commit rG0dac639f285a: [Clang][Sema] Capturing section type conflicts
on #pragma clang section (authored by pratlucas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
pratlucas updated this revision to Diff 262592.
pratlucas added a comment.
Addressing review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78572/new/
https://reviews.llvm.org/D78572
Files:
clang/include/clang/AST/ASTContext.h
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Seems reasonable.
Comment at: clang/test/Sema/pragma-clang-section.c:2
// RUN: %clang_cc1 -fsyntax-only -verify %s -triple arm-none-eabi
-#pragma clang section bss="mybss.1"
pratlucas updated this revision to Diff 259593.
pratlucas added a comment.
Rebasing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78572/new/
https://reviews.llvm.org/D78572
Files:
clang/include/clang/AST/ASTContext.h
pratlucas updated this revision to Diff 259039.
pratlucas added a comment.
Fixing missing clang-format messages.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78572/new/
https://reviews.llvm.org/D78572
Files:
pratlucas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Section names used in clang section pragmas were not validated against
previously defined sections, causing section type conflicts to be
ignored by Sema.
This patch enables Clang to capture
