Re: [PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

yes that's the case. See https://github.com/clangd/vscode-clangd/pulls?q=is%3Apr On Mon, May 11, 2020 at 9:57 AM Nathan Ridge via Phabricator < revi...@reviews.llvm.org> wrote: > nridge added a comment. > > Also, does this mean that patches to vscode-clangd should now be submitted > as a Github

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

nridge added a comment. Also, does this mean that patches to vscode-clangd should now be submitted as a Github PR rather than via Phabricator? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78598/new/ https://reviews.llvm.org/D78598

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG161afc01064b: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

sammccall added a comment. In D78598#1995939 , @nridge wrote: > Is there an easy way to transplant patches written against the old repo, into > the new one? If you have a patch file (from git format-patch or downloaded from phab), you should be able

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for doing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78598/new/ https://reviews.llvm.org/D78598

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

hokein added a comment. > Is there an easy way to transplant patches written against the old repo, into > the new one? I don't know whether there is an easy way, I'd just copy the changed file from the old repo to new repo, and regenerate a diff, I think this is not too terrible given that we

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

nridge added a comment. Is there an easy wasy to transplant patches written against the old repo, into the new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78598/new/ https://reviews.llvm.org/D78598

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Moving this out of the monorepo for consistency with other editor plugins. There's no version