This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d1ee639cb9e: [clangd] Fix a crash for accessing a null
template decl returned by… (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1293
+struct Base {};
+namespace foo {
+template
kadircet wrote:
> is namespace required?
yes, the
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1293
+struct Base {};
+namespace foo {
+template
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Fixes https://github.com/clangd/clangd/issues/347.
Repository:
rG LLVM Github Monorepo