This revision was automatically updated to reflect the committed changes.
Closed by commit rG873e27909539: [SemaObjC] Add a warning for dictionary
literals with duplicate keys (authored by erik.pilkington).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
rjmccall accepted this revision.
rjmccall added a comment.
Anyway, LGTM.
Comment at: clang/lib/Sema/SemaExprObjC.cpp:948
+checkOneKey(IntegralKeys, Result.Val.getInt(), Loc);
+ }
+}
erik.pilkington wrote:
> bendjones wrote:
> > rjmccall wrote:
erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaExprObjC.cpp:948
+checkOneKey(IntegralKeys, Result.Val.getInt(), Loc);
+ }
+}
bendjones wrote:
> rjmccall wrote:
> > Does `Eva
bendjones accepted this revision.
bendjones marked an inline comment as done.
bendjones added a comment.
This revision is now accepted and ready to land.
This addresses what we had an issue with on the tin. I’ll defer to @rjmccall
for the specifics at the clang level.
Comment
rjmccall added a comment.
Some part of me wishes we could use expression profiling or ODR hashing or
something like that for this, but I guess the semantics we're going for don't
really match.
Comment at: clang/lib/Sema/SemaExprObjC.cpp:948
+checkOneKey(IntegralKeys,
erik.pilkington added a comment.
Ping!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78660/new/
https://reviews.llvm.org/D78660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, bendjones.
Herald added subscribers: ributzka, dexonsmith, jkorous.
Duplicate keys in a literal break NSDictionary's invariants.
Fixes rdar://50454461
Repository:
rC Clang
https://reviews.llvm.org/D78660
Files
