[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

2020-04-23 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG14aaf4457c64: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

2020-04-22 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the helping get the patch upstreamed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

2020-04-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 259398. MaskRay marked an inline comment as done. MaskRay added a comment. Change RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 Files:

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

2020-04-22 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/test/Sema/implicit-int-float-conversion.c:3 +// RUN: %clang_cc1 %s -verify -Wimplicit-const-int-float-conversion +// RUN: %clang_cc1 %s -DNONCONST=1 -verify -Wimplicit-int-float-conversion If I

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

2020-04-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 259370. MaskRay added a comment. Fixed a typo noticed by @bmoses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

2020-04-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: aaron.ballman, jfb, nickdesaulniers, rsmith, scanon, xbolva00, ziangwan. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Currently, both `warn_impcast_integer_float_precision_constant` and