This revision was automatically updated to reflect the committed changes.
Closed by commit rG823e2a670a9d: [SveEmitter] Add builtins for contiguous
prefetches (authored by sdesmalen).
Changed prior to commit:
https://reviews.llvm.org/D78674?vs=259587=259851#toc
Repository:
rG LLVM Github
efriedma accepted this revision.
efriedma added a comment.
LGTM
Comment at:
clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfb.c:22
+ // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+ return svprfb(pg, base, -1);
+}
sdesmalen marked an inline comment as done.
sdesmalen added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7727
+ Value *Offset = Ops.size() > 3 ? Ops[2] : Builder.getInt32(0);
+ BasePtr = Builder.CreateGEP(MemoryTy, BasePtr, Offset);
+
efriedma
sdesmalen updated this revision to Diff 259587.
sdesmalen marked an inline comment as done.
sdesmalen added a comment.
- Don't emit bitcast+gep+bitcast when offset is 0.
- Added negative tests for _vnum cases.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78674/new/
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with a couple minor comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7727
+ Value *Offset = Ops.size() > 3 ? Ops[2] : Builder.getInt32(0);
+ BasePtr =
sdesmalen updated this revision to Diff 259403.
sdesmalen added a comment.
- Removed unrelated whitespace changes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78674/new/
https://reviews.llvm.org/D78674
Files:
clang/include/clang/Basic/TargetBuiltins.h
sdesmalen created this revision.
sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau.
Herald added a subscriber: tschuett.
Herald added a project: clang.
sdesmalen updated this revision to Diff 259403.
sdesmalen added a comment.
- Removed unrelated whitespace changes.
This patch also
