sdesmalen marked an inline comment as done.
sdesmalen added a comment.
Thanks for reviewing!
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7739
+
+// Index needs to be passed as scaled offset.
+llvm::Type *MemEltTy = SVEBuiltinMemEltTy(TypeFlags);
This revision was automatically updated to reflect the committed changes.
Closed by commit rG42a56bf63f69: [SveEmitter] Add builtins for gather
prefetches (authored by sdesmalen).
Changed prior to commit:
https://reviews.llvm.org/D78677?vs=259589=260879#toc
Repository:
rG LLVM Github
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with one minor comment
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7739
+
+// Index needs to be passed as scaled offset.
+llvm::Type *MemEltTy =
sdesmalen updated this revision to Diff 259589.
sdesmalen added a comment.
- Updated the tests to use `SVE_ACLE_FUNC` for the overloaded builtins.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78677/new/
https://reviews.llvm.org/D78677
Files:
sdesmalen created this revision.
sdesmalen added reviewers: SjoerdMeijer, efriedma.
Herald added a subscriber: tschuett.
Herald added a project: clang.
sdesmalen added a parent revision: D78674: [SveEmitter] Add builtins for
contiguous prefetches.
Repository:
rG LLVM Github Monorepo