[PATCH] D78699: [X86] Passing union type through register.

2020-10-13 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added a comment. In D78699#2328541 , @dyung wrote: > Hi, the test you added seems to pass both before and after your change, is > this intended? Oh, yes. I made mistake on my RUN line. So these tests are not really checked. Thanks for your help

[PATCH] D78699: [X86] Passing union type through register.

2020-10-13 Thread Douglas Yung via Phabricator via cfe-commits
dyung added inline comments. Comment at: clang/test/CodeGen/X86/avx-union.c:2 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX +// RUN: %clang_cc1 -w -ffreestanding -triple x86_

[PATCH] D78699: [X86] Passing union type through register.

2020-10-13 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi, the test you added seems to pass both before and after your change, is this intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[PATCH] D78699: [X86] Passing union type through register.

2020-10-08 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added a comment. In D78699#2320678 , @bruno wrote: > LGTM Thanks for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[PATCH] D78699: [X86] Passing union type through register.

2020-10-08 Thread LiuChen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG26cfb6e562f1: [X86] Passing union type through register (authored by LiuChen3). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE