[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen added a comment. I have reverted the patch in the meantime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen added a comment. In D78750#2018673 , @thakis wrote: > Looks like this breaks check-clang on Windows: > http://45.33.8.238/win/14483/step_7.txt > > And some other bots: > > http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/b

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

thakis added a comment. Looks like this breaks check-clang on Windows: http://45.33.8.238/win/14483/step_7.txt And some other bots: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/37883/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aacle_sve_dupq.c http://lab.llvm.

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

This revision was automatically updated to reflect the committed changes. sdesmalen marked an inline comment as done. Closed by commit rG6b90a6887d25: [SveEmitter] Add builtins for svdupq and svdupq_lane (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 ___ cfe-commits mailing list cfe-commi

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8054 + +Value *Alloca = Builder.CreateAlloca(EltTy, Builder.getInt32(NumOpnds)); +for (unsigned I = 0; I < NumOpnds; ++I) efriedma wro

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen updated this revision to Diff 261853. sdesmalen added a comment. - Use CreateTempAlloca instead of CreateAlloca - Added checks for alignment to the stores. - Added test with control-flow to check the alloca is added to the entry-block. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8054 + +Value *Alloca = Builder.CreateAlloca(EltTy, Builder.getInt32(NumOpnds)); +for (unsigned I = 0; I < NumOpnds; ++I) Please use something like `CreateTempAlloca(llvm::ArrayTy

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:98 + bool isScalarPredicate() const { +return !Float && Predicate && NumVectors == 0; + } note: the changes to isScalarPredicate and

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen updated this revision to Diff 261545. sdesmalen added a comment. - Re-added patch with diff context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 Files: clang/include/clang/Basic/arm_sve.td clang/lib/CodeGen/CGBuiltin.cpp clan

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen added a comment. In D78750#2009037 , @efriedma wrote: > Is there some reason you decided to implement these particular functions as > inline functions directly in the header? Earlier implementations of the ACLE had a lot more things done in th

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen updated this revision to Diff 261537. sdesmalen added a comment. - Moved dupq implementation to CGBuiltins CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 Files: clang/include/clang/Basic/arm_sve.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma added a comment. Is there some reason you decided to implement these particular functions as inline functions directly in the header? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78748: [SveEmitter] Add builtins for svld1rq. - svdupq builtins that duplicate scalars to every qua