This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0c356582d2f: [NFC][clang] Replace raw new/delete with
unique_ptr to store ABIInfo in… (authored by jasonliu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
hubert.reinterpretcast added a comment.
Funny that it's the front-end code that this patch makes more C++11 after so
many years. LGTM; thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79033/new/
https://reviews.llvm.org/D79033
___
cfe
jasonliu updated this revision to Diff 260766.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79033/new/
https://reviews.llvm.org/D79033
Files:
clang/lib/CodeGen/TargetInfo.cpp
clang/lib/CodeGen/TargetInfo.h
Index: clang/lib/CodeGen/TargetInfo.h
==
jasonliu updated this revision to Diff 260746.
jasonliu added a comment.
Provide default virtual destructor.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79033/new/
https://reviews.llvm.org/D79033
Files:
clang/lib/CodeGen/TargetInfo.cpp
clang/lib/CodeGen/TargetInfo.h
Index: clang
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.h:51
- TargetCodeGenInfo(ABIInfo *info = nullptr) : Info(info) {}
- virtual ~TargetCodeGenInfo();
I'm not sure removing a virtual destructor is a good idea. The use of `del
jasonliu created this revision.
jasonliu added reviewers: hubert.reinterpretcast, sfertile, nemanjai,
Xiangling_L.
Herald added subscribers: s.egerton, simoncook, fedor.sergeev, aheejin, dschuff.
Herald added a project: clang.
Use unique_ptr to manage the lifetime of ABIInfo member inside
Target
