This revision was automatically updated to reflect the committed changes.
Closed by commit rG19f5da9c1d69: [SVE][Codegen] Lower legal min max
operations (authored by kmclaughlin).
Changed prior to commit:
https://reviews.llvm.org/D79087?vs=261462=261787#toc
Repository:
rG LLVM Github
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79087/new/
https://reviews.llvm.org/D79087
___
cfe-commits mailing list
kmclaughlin marked an inline comment as done.
kmclaughlin added inline comments.
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>;
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>;
}
efriedma wrote:
>
kmclaughlin updated this revision to Diff 261462.
kmclaughlin added a comment.
- Added tests for the intrinsics where the second operand is an immediate
- Changed the range SelectSVESignedArithImm checks for, as the range for the
immediates of smin & smax is -128 to +127 (inclusive)
CHANGES
efriedma added inline comments.
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>;
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>;
}
kmclaughlin wrote:
> efriedma wrote:
> > I don't see any test for
kmclaughlin marked an inline comment as done.
kmclaughlin added inline comments.
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>;
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>;
}
efriedma wrote:
>
efriedma added a subscriber: huihuiz.
efriedma added inline comments.
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>;
+ def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>;
}
I don't see any test for this
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, efriedma, dancgr.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
This patch adds AArch64ISD nodes for [S|U]MIN_PRED
and
