This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG2cf93ef9fe1d: [clangd] Render doc-comment code spans with
`backticks` in plaintext mode (authored by sammccall).
Changed prior to commit:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM thanks!
Comment at: clang-tools-extra/clangd/FormattedString.cpp:365
+llvm::StringRef Marker = "";
+if (C.Preserve && C.Kind == Chunk::InlineCode)
+
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/FormattedString.cpp:365
+llvm::StringRef Marker = "";
+if (C.Preserve && C.Kind == Chunk::InlineCode)
+ Marker = "`";
kadircet wrote:
>
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/FormattedString.cpp:365
+llvm::StringRef Marker = "";
+if (C.Preserve && C.Kind == Chunk::InlineCode)
+ Marker = "`";
should we rather use `renderInlineBlock` here ? because in
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D79142
Files:
