[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc7a907b93a: Let normalize() for posix style convert backslash to slash unconditionally. (authored by thakis). Herald added a project: clang. Changed prior to commit:

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, especially since none of the other tests break. I don't fully remember the reason for the special case, and if it ever turns up, we can address it then. CHANGES SINCE

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis updated this revision to Diff 261980. thakis added a comment. restore else CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79265/new/ https://reviews.llvm.org/D79265 Files: clang/test/Lexer/case-insensitive-include-ms.c llvm/lib/Support/Path.cpp

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis added a comment. In D79265#2018770 , @compnerd wrote: > What happens if you encounter a `"\t"` as a string? This would convert that > to a `"/t"` would it not? Although, I suppose that in practice the treatment > of escaped characters is not

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd added a comment. What happens if you encounter a `"\t"` as a string? This would convert that to a `"/t"` would it not? Although, I suppose that in practice the treatment of escaped characters is not important. I think I still prefer the `} else {` here over the early return.

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis created this revision. thakis added a reviewer: compnerd. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Currently, normalize() for posix replaces backslashes to slashes, except that two backslashes in sequence are kept as-is. clang calls normalize() to convert \ to /