[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa549c0d00486: Fix template class debug info for Visual Studio visualizers (authored by amccarth). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth updated this revision to Diff 263790. amccarth added a comment. Addressed feedback, specifically: - Distinction is now on CodeView generation rather than -fms-compatibility. - Tests two --std= levels plus the default one. CHANGES SINCE LAST ACTION

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth marked 2 inline comments as done. amccarth added a comment. Made the requested changes after an in-person conversation to clear up my earlier confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp:10 +// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ +// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -fms-compatibility | \ +//

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth marked 2 inline comments as done. amccarth added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp:10 +// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ +// RUN: -o - -triple=x86_64-pc-win32

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp:10 +// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ +// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -fms-compatibility | \ +//

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth updated this revision to Diff 262499. amccarth added a comment. Updated an existing test. Thanks for the pointer; I had gotten myself completely confused about the organization of the test directories. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth added a comment. Updated test to validate the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk added a comment. I think testing it is a matter of adding later C++ standard versions to the existing test here: `../clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

aprantl added a comment. This should be testable with a -emit-llvm test FileChecking the generated IR? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth created this revision. amccarth added reviewers: rnk, hans. Herald added a subscriber: aprantl. An earlier change eliminated spaces between the close brackets of nested template lists. Unfortunately that prevents the Windows debuggers from matching some types to their corresponding