[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c4b8bd6869: [analyzer] Generalize bitwise OR rules for ranges (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 264615. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 264602. vsavchenko added a comment. Fix a bug with double expressions withing integer expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 262171. vsavchenko added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 262163. vsavchenko added a comment. Fix few things here and there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Math looks good to me :) Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:388 + /// it will return the range [x_0, y_N]. + static Range roughen(RangeSet

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole tree to get to the last element.

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko marked 3 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole tree to get to the last element.

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko added a comment. Here is a little proof I've put together (using Z3): https://gist.github.com/SavchenkoValeriy/9ad6ca72e7420fd5612e618187bd4f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko added