[PATCH] D79367: [CUDA][HIP] Fix empty ctor/dtor check for union

2020-05-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd75a6e93ae99: [CUDA][HIP] Fix empty ctor/dtor check for union (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D79367: [CUDA][HIP] Fix empty ctor/dtor check for union

2020-05-04 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice! Thank you for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79367/new/ https://reviews.llvm.org/D79367 ___ cfe-commits mailin

[PATCH] D79367: [CUDA][HIP] Fix empty ctor/dtor check for union

2020-05-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. union ctor does not call ctors of its data members. union dtor does not call dtors of its data members. Also union does not have base class. https://godbolt.org/z/8RxZeG Currently when clang checks whether union has an empty c