[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b9b11fea3e: Dont assert about missing profile info in createProfileWeightsForLoop (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis added a comment. Fair enough :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

hans added a comment. In D79417#2020607 , @thakis wrote: > Could there be a test for this? Or is that difficult? I think it would be a bit of a pain, which is why I skipped it. It also wouldn't be a very interesting test, just "don't assert here",

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Could there be a test for this? Or is that difficult? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

hans created this revision. hans added reviewers: thakis, rnk. The compiler shouldn't crash if the profile info is slightly off. We hit this in Chromium. https://reviews.llvm.org/D79417 Files: clang/lib/CodeGen/CodeGenPGO.cpp Index: clang/lib/CodeGen/CodeGenPGO.cpp