This revision was automatically updated to reflect the committed changes.
Closed by commit rGe71c537a487c: [clang-format] Fix line lengths w/ comments in
align (authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79465/new/
JakeMerdichAMD added a comment.
Hey @MyDeveloperDay, can I get your assistance committing this when you have
the chance?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79465/new/
https://reviews.llvm.org/D79465
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79465/new/
https://reviews.llvm.org/D79465
JakeMerdichAMD updated this revision to Diff 264294.
JakeMerdichAMD added a comment.
Rebase to fix merge conflict
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79465/new/
https://reviews.llvm.org/D79465
Files:
JakeMerdichAMD updated this revision to Diff 264259.
JakeMerdichAMD added a comment.
Add a comment explaining why checking IsInsideToken is needed here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79465/new/
https://reviews.llvm.org/D79465
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/WhitespaceManager.cpp:417
+LineLengthAfter += Changes[j].TokenLength;
+}
unsigned ChangeMaxColumn = Style.ColumnLimit - LineLengthAfter;
could you help us here with a comment, I
MyDeveloperDay added a comment.
I've been able to reproduce and the patch looks good, I've just not had a
chance to read the review in-depth (I don't know this section of the code as
well as other parts).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
