[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-19 Thread Xiang Zhang via Phabricator via cfe-commits
xiangzhangllvm added a comment. Hello rsmith, first, very sorry for have committed this patch before your reply, I waited 10 days, I thought you have agreed it. I think the linux-ABI can be the specification of this head file. The context of this cet.h is according to the linux ABI about

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-19 Thread H.J Lu via Phabricator via cfe-commits
hjl.tools added a comment. In D79617#2045552 , @rsmith wrote: > I would like a specification for this header to be added somewhere. We > shouldn't be implementing random things with no specification. (Suppose > someone claims that our `` is wrong in

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-19 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I would like a specification for this header to be added somewhere. We shouldn't be implementing random things with no specification. (Suppose someone claims that our `` is wrong in some way. How would we know whether they're right?) Ideally, I'd also like this header

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-19 Thread Xiang Zhang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc0c894f38f: Add cet.h for writing CET-enabled assembly code (authored by xiangzhangllvm). Changed prior to commit: https://reviews.llvm.org/D79617?vs=264772=264799#toc Repository: rG LLVM Github

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-18 Thread Xiang Zhang via Phabricator via cfe-commits
xiangzhangllvm added a comment. @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79617/new/ https://reviews.llvm.org/D79617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-18 Thread Tom Stellard via Phabricator via cfe-commits
tstellar reopened this revision. tstellar added a comment. This revision is now accepted and ready to land. Did @rsmith ever approve this patch? I was following the discussion at llvm.org/PR45484 but did not see an explicit approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

2020-05-18 Thread Xiang Zhang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe7e84ff24a5f: Add cet.h for writing CET-enabled assembly code (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo