[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

2020-05-15 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki abandoned this revision. davezarzycki added a comment. I'm going to abandon this change for now. The problem is that the MS extensions are not as pervasive through the language as I wanted. For example, I'd really like them to work on aggregate types. This would allow all of the

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

2020-05-09 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. In D79673#2028204 , @rnk wrote: > Needs a test. > > I believe these are only implemented for x86 in LLVM. What happens if you try > to use this on non-x86? I wouldn't be surprised if we crash, but we should > probably

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

2020-05-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Needs a test. I believe these are only implemented for x86 in LLVM. What happens if you try to use this on non-x86? I wouldn't be surprised if we crash, but we should probably produce a proper error and test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

2020-05-09 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki created this revision. davezarzycki added reviewers: akhuang, rnk, rsmith. davezarzycki added a project: clang. Herald added a reviewer: aaron.ballman. One should not need to use `-fms-extensions` in order to use 32-bit pointers on 64-bit platforms. Repository: rG LLVM Github