[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG774acdfb8c46: [clangd] Add metrics for selection tree and recovery expressions. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D79701?vs=263382&id=263433#toc Repository: rG L

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:454 + auto T = makeSelectionTree(Code, AST); + // EXPECT_THAT(Tracer.takeMetric("selection"), te

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

hokein updated this revision to Diff 263382. hokein marked 2 inline comments as done. hokein added a comment. address comments, and remove the fixme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79701/new/ https://reviews.llvm.org/D79701 Files:

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:39 +void recordMetrics(const SelectionTree &S) { + static constexpr trace::Metric Selection("selection", trace::Metric::Counter); this deserves a comment about what we're trac

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79701 Files: clang-tools-extra/clangd/Sele