[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b137a430636: [clang][BFloat] Add create/set/get/dup intrinsics (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 268528. miyuki added a comment. Fixed the "RUN:" line in the A32 test, implemented vduph_lane for A32. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-03 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 268162. miyuki retitled this revision from "[clang][BFloat] add create/set/get/dup intrinsics" to "[clang][BFloat] Add create/set/get/dup intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Addressed reviewers' comments. CHANGES

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-06-03 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1860 + + def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>; + def VGET_LOW_BF : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>; dmgreen wrote: > Do you know what InstName

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-06-02 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1854 + def VDUP_LANE_BF : WOpInst<"vdup_lane", ".qI", "bQb", OP_DUP_LN>; + def VDUP_LANEQ_BF: WOpInst<"vdup_laneq", ".QI", "bQb", OP_DUP_LN> { +let

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-06-01 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1854 + def VDUP_LANE_BF : WOpInst<"vdup_lane", ".qI", "bQb", OP_DUP_LN>; + def VDUP_LANEQ_BF: WOpInst<"vdup_laneq", ".QI", "bQb", OP_DUP_LN> { +let isLaneQ = 1; My local

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-29 Thread Dave Green via Phabricator via cfe-commits
dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1860 + + def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>; + def VGET_LOW_BF : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>; Do you know what InstName = "vmov" does,

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-22 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 265764. stuij added a comment. moving 'CartesianProductWith' to more apt patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files:

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-21 Thread Ties Stuij via Phabricator via cfe-commits
stuij added a comment. In D79710#2041418 , @LukeGeeson wrote: > Can you update the commit message in this differential as well please? Same > for the other commits :) done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-20 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1845 + +// V8.2-A BFloat intrinsics +let ArchGuard = "defined(__ARM_FEATURE_BF16_VECTOR_ARITHMETIC)" in { labrinea wrote: > v8.6-A ? Yes

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-20 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1845 + +// V8.2-A BFloat intrinsics +let ArchGuard = "defined(__ARM_FEATURE_BF16_VECTOR_ARITHMETIC)" in { v8.6-A ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-18 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson added a comment. Can you update the commit message in this differential as well please? Same for the other commits :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-18 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 264588. stuij added a comment. adhere to patch attribution conventions: change author to Ties, add all the contributors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-13 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson added a comment. I was an author for part of this patch. Please add all authors as a list of authors to this commit message. Thanks! As an aside, it would be worth doing this for all the patches in this series Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

2020-05-13 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-getset-intrinsics.c:119-120 +// CHECK-LABEL: test_vduph_laneq_bf16 +// CHECK64: %vgetq_lane = extractelement <8 x bfloat> %v, i32 7 +// CHECK32: %vget_lane = extractelement <8 x bfloat> %v, i32 7