[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-21 Thread Daniel Grumberg via Phabricator via cfe-commits
dang abandoned this revision. dang added a comment. This revision is superseded by D80383 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-20 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 265263. dang added a comment. Uploaded the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/incl

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-20 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 265262. dang added a comment. Herald added a subscriber: ormris. Add a small bug fix and test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 Files: clang/test/Modu

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. In D79998#2038430 , @dang wrote: > Should I add the test here or in the clang-scan-deps patch? It's best to have a test in every non-nfc patch. You should be able to test this with llvm-bcanalyzer. Repository: rG LLVM Gith

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. Should I add the test here or in the clang-scan-deps patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 ___ cfe-commits mailing list c

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. This lets users of PCM get a clean hash of the AST for uniquing based on that. This required looking up implicit modules in the module offset map to be lo