[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bf2409a4e4d: [AIX] Add -bcdtors:all:0:s to linker to gather static init functions (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265818. stevewan added a comment. Update check prefix based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks. LGTM with minor nit. In D80415#2051772 , @stevewan wrote: > I'm planning to post an NFC patch after this to

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan added a comment. I'm planning to post an NFC patch after this to fix the formatting for existing cases in 'aix-ld.c' so that everything is consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265813. stevewan added a comment. Incorporate the test case into 'aix-ld.c'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files:

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors \ stevewan

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors \ I am

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265781. stevewan added a comment. Address furthur comments on the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files:

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:18 +// CHECK-LD32-ARG-ORDER: "-bnocdtors" +// CHECK-LD32-ARG-ORDER: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD32-ARG-ORDER: "-lc" The main point of the test being that

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:9 +// CHECK-LD32-ARG-ORDER-NOT: warning: +// CHECK-LD32-ARG-ORDER: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" +// CHECK-LD32-ARG-ORDER: "-isysroot"

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265765. stevewan added a comment. Address comments and fix windows compatibility issues with the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files:

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:1 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order. +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ ZarkoCA wrote: >

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:3 +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// // RUN: -Wl,-bnocdtors \ +// // RUN: -target powerpc-ibm-aix7.1.0.0 \ formatting, align with the line

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:1 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order. +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ s/Arguemnt/Argument/ Comment

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: hubert.reinterpretcast, Xiangling_L, ZarkoCA, daltenty. On AIX, add '-bcdtors:all:0:s' to linker implicitly through driver, so that we can collect all static