hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang/lib/AST/Decl.cpp:4129
SourceRange TagDecl::getSourceRange() const {
- SourceLocation RBraceLoc = BraceRange.getEnd();
- SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation();
sammccall added inline comments.
Comment at: clang/lib/AST/Decl.cpp:4129
SourceRange TagDecl::getSourceRange() const {
- SourceLocation RBraceLoc = BraceRange.getEnd();
- SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation();
+ SourceLocation E = BraceRange.getBe
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang/lib/AST/Decl.cpp:4129
SourceRange TagDecl::getSourceRange() const {
- SourceLocation RBraceLoc = BraceRange.getEnd();
- SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation();
sammccall added a comment.
Argh I never submitted these comments, sorry.
Comment at: clang/lib/AST/Decl.cpp:4129
SourceRange TagDecl::getSourceRange() const {
- SourceLocation RBraceLoc = BraceRange.getEnd();
- SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation
hokein created this revision.
hokein added reviewers: sammccall, akyrtzi.
Herald added subscribers: usaxena95, kadircet, arphaman, dexonsmith, jkorous,
ilya-biryukov.
Herald added a project: clang.
The AST is preserved when the TagDecl misses a } brace, but the source
range seems incorrect (just