This revision was automatically updated to reflect the committed changes.
Closed by commit rG21ccc684ff4c: [AST][RecoveryExpr] Build RecoveryExpr for
undef_var cases. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80733/new/
hokein added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:8310
+// to RecoveryExpr.
+// FIXME: we lose source locations for RecoveryExpr, as TypoExpr doesn't
+// track source locations.
sammccall wrote:
> This seems reasonably
hokein updated this revision to Diff 267873.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80733/new/
https://reviews.llvm.org/D80733
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice!
Comment at: clang/lib/Sema/SemaExprCXX.cpp:8310
+// to RecoveryExpr.
+// FIXME: we lose source locations for RecoveryExpr, as TypoExpr doesn't
+//
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
Herald added a project: clang.
For a no-function-like unresolved expression, clang builds a TypoExpr
for it, and tries to correct it afterwards. If the
