[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80735/new/ https://reviews.llvm.org/D80735 ___

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1,

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8*

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. Here's one of the stack traces. Calling `InternalOMPBuilder.initialize()` is what triggers it to start failing, which is confusing because all that function does is initialize the named types from OMPConstants, which should be working or else the old solution wouldn't

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added a comment. In D80735#2073639 , @jhuber6 wrote: > The failure message is pretty much always this assertion as far as I can tell > > clang-11: > /home/jhuber/Documents/llvm-project/llvm/lib/IR/Instructions.cpp:439: void >

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. The failure message is pretty much always this assertion as far as I can tell clang-11: /home/jhuber/Documents/llvm-project/llvm/lib/IR/Instructions.cpp:439: void llvm::CallInst::init(llvm::FunctionType*, llvm::Value*, llvm::ArrayRef, llvm::ArrayRef >, const

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added a comment. In D80735#2071897 , @jhuber6 wrote: > I'm just investigating migrating D80222 > away from the static methods. When I try to just add an OpenMPIRBuilder type > and initialize it I get failures

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. I'm just investigating migrating D80222 away from the static methods. When I try to just add an OpenMPIRBuilder type and initialize it I get failures on the tests. I'm just adding in the module as you have `CGOpenMPRuntime.h`

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:376 + /// generation. + llvm::OpenMPIRBuilder InternalOMPBuilder; jhuber6 wrote: > Should D80222 be changed to use this instead and