[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8eda71616fec: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. thanks homies, committed as https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

efriedma accepted this revision. efriedma added a comment. LGTM. For non-Android, I think it makes sense to align with gcc as much as possible. > This is mostly > for legacy/compatibility reasons, and the 2019 Q4 revision of the ARM > AAPCS looks to standardize r11 as the frame pointer for

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

psmith accepted this revision. psmith added a comment. LGTM from an Arm person now that the Android changes have been made. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22 #include "InputInfo.h" +#include "MSP430.h" #include "PS4CPU.h" nickdesaulniers

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

MaskRay added a subscriber: olista01. MaskRay added a comment. In D80828#2069287 , @nickdesaulniers wrote: > May I please have a non-Googler to review+(accept|reject) the revision? I guess @olista01 is an inactive account. Changed to @ostannard

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. May I please have a non-Googler to review+(accept|reject) the revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 ___

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. In D80828#2067110 , @MaskRay wrote: > (You can change `[Clang]` to `[Driver]` as `[Clang]` may carry less > information. `[Driver]` emphasizes this is related to clangDriver. Nothing in > sema/codegen/analyzer/etc is

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

MaskRay accepted this revision. MaskRay added a comment. (You can change `[Clang]` to `[Driver]` as `[Clang]` may carry less information. `[Driver]` emphasizes this is related to clangDriver. Nothing in sema/codegen/analyzer/etc is affected.) Repository: rG LLVM Github Monorepo CHANGES