[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-07 Thread Qing Shan Zhang via Phabricator via cfe-commits
steven.zhang added a comment. The PowerPC backend is also adding the constraint float point support and almost done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 __

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-02 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. In D80952#2067643 , @arsenm wrote: > In D80952#2067563 , @efriedma wrote: > > > The problem for the command-line arguments in particular is that they > > aren't really new; clang has been eatin

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-01 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D80952#2067563 , @efriedma wrote: > The problem for the command-line arguments in particular is that they aren't > really new; clang has been eating them for a long time, without any warning. > So if -frounding-math crashes th

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-01 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. The problem for the command-line arguments in particular is that they aren't really new; clang has been eating them for a long time, without any warning. So if -frounding-math crashes the compiler, that's a regression. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-01 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a subscriber: wdng. If this chooses to just blindly ignore the setting, how is development supposed to be done on other targets? I'd prefer if this behaved more like -fg

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-01 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Clang :: Misc/warning-flags.c Like the file says, all warnings should be controlled by a -W flag. If you're going to add a new warning, you need a corresponding flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-01 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn created this revision. kpn added reviewers: cameron.mcinally, craig.topper, andrew.w.kaylor, spatel, wristow, nemanjai. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. kpn added a comment. This currently triggers a failure in test "Clang :: Misc/warning-flags.c

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

2020-06-01 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. This currently triggers a failure in test "Clang :: Misc/warning-flags.c". Suggestions on how to fix that correctly are welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 _