[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

2020-06-06 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

2020-06-05 Thread Steven Wan via Phabricator via cfe-commits
stevewan added a comment. Looks like this has broken the build bot? (see http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

2020-06-05 Thread Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

2020-06-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > but the operator declared at global scope returns void. void -> void pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

2020-06-01 Thread Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 267767. rnk added a comment. - revert lld change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

2020-06-01 Thread Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added a reviewer: akhuang. Herald added a reviewer: MaskRay. Herald added a project: clang. rnk updated this revision to Diff 267767. rnk added a comment. - revert lld change Clang marks calls to operator new as heap allocation sites, but the operator declared at