[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb465a329e2: [DebugInfo] Fix assertion for extern void type (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81131/new/

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81131/new/ https://reviews.llvm.org/D81131

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song updated this revision to Diff 268995. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added subscribers: llvm-commits, hiraditya, aprantl. Herald added a project: LLVM. instead of skipping generating debuginfo for "extern void var_name", do

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song added a comment. Thanks, @dblaikie >> I think if we're going to support "const void" we should support "void" too >> & fix the verifier to allow this & make sure LLVM produces the correct debug >> info for it (which is probably a DW_TAG_variable without a DW_AT_type >> attribute

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

dblaikie added a comment. Patches without tests shouldn't be approved - and at least the usual/rough metric I use for patch approval is (most often - unless I'm reviewing the work of the code owner in any area who wants a second opinion, etc) - I approve it if I'd be willing to commit a

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. For my purposes, having extern var BTF only for `extern const void` is just fine. Not crashing Clang for `extern void` is great as well :) Repository: rG LLVM Github Monorepo

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. yonghong-song added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit d77ae1552fc2