aaron.ballman added a comment.
I haven't quite figured out the proper phab workflow for reverts yet either,
but I took the updated patch, applied it, and commit in r259359. Thank you for
the fix!
http://reviews.llvm.org/D8149
___
cfe-commits
LegalizeAdulthood added a comment.
If someone could commit this for me, that would be great. I do not have commit
access.
Patch by Richard Thomson
http://reviews.llvm.org/D8149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit as r259210.
http://reviews.llvm.org/D8149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood updated this revision to Diff 46464.
LegalizeAdulthood added a comment.
Fix RegistryTest unit test
make check-all passes
http://reviews.llvm.org/D8149
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
LegalizeAdulthood added a comment.
It seems that phabricator hasn't been configured to allow me to reopen the
revision, but I've updated the diff.
http://reviews.llvm.org/D8149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
LegalizeAdulthood updated this revision to Diff 46341.
LegalizeAdulthood added a comment.
Update from review comments, add test case
http://reviews.llvm.org/D8149
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM with one addition, I still would like to see this test added and passing:
EXPECT_TRUE(matchesC("void f();", functionDecl(parameterCountIs(0;
Thank you for working on these!
http://reviews.llvm.org/D8149
